Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate integer types for L1T and HLT prescales in HLTConfigData and its clients [12_5_X] #39446

Merged
merged 1 commit into from
Sep 21, 2022
Merged

deprecate integer types for L1T and HLT prescales in HLTConfigData and its clients [12_5_X] #39446

merged 1 commit into from
Sep 21, 2022

Conversation

missirol
Copy link
Contributor

@missirol missirol commented Sep 19, 2022 •
edited
Loading

backport of #39220

PR description:

A full description of the scope and implementation of this PR can be found in #39220.

Summary:

  • support only double and FractionalPrescale as valid types to access the values of L1T and HLT prescales in HLTConfigData and all of its clients (e.g. HLTConfigProvider, HLTPrescaleProvider, PATTriggerProducer, etc);
  • client code in CMSSW is updated accordingly; user code outside CMSSW that uses these methods will run into a compile-time error, in order to force users to specify one of the supported types (avoiding silent conversion of non-integer values into integers in user code);
  • a bi-product of this PR is a bugfix to MINIAOD, which has so far mistakenly saved L1T prescales as integers (even though in Run 3 L1T prescales can actually have non-integer values); this requires a change in DataFormats/PatCandidates.

Verbatim backport.

PR validation:

Relies on the validation done for the original PR.

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:

#39220

Bugfix for MINIAOD.

@cmsbuild cmsbuild added this to the CMSSW_12_5_X milestone Sep 19, 2022
@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 19, 2022 •
edited
Loading

A new Pull Request was created by @missirol (Marino Missiroli) for CMSSW_12_5_X.

It involves the following packages:

  • Alignment/OfflineValidation (alca)
  • Calibration/HcalCalibAlgos (alca)
  • Calibration/IsolatedParticles (alca)
  • CommonTools/TriggerUtils (hlt, l1)
  • DPGAnalysis/Skims (pdmv)
  • DQM/Physics (dqm)
  • DQMOffline/Trigger (dqm)
  • DataFormats/PatCandidates (reconstruction)
  • HLTrigger/HLTanalyzers (hlt)
  • HLTrigger/HLTcore (hlt)
  • PhysicsTools/Heppy (analysis)
  • PhysicsTools/PatAlgos (reconstruction)
  • PhysicsTools/TagAndProbe (analysis)
  • Validation/RecoVertex (dqm)

@syuvivida, @bbilin, @Martin-Grunewald, @rekovic, @ChrisMisan, @cecilecaillol, @yuanchao, @ahmad3213, @cmsbuild, @missirol, @mandrenguyen, @pmandrik, @epalencia, @emanueleusai, @jfernan2, @kskovpen, @micsucmed, @francescobrivio, @malbouis, @clacaputo, @saumyaphor4252, @sunilUIET, @rvenditti, @tvami can you please review it and eventually sign? Thanks.
@rappoccio, @gouskos, @VourMa, @felicepantaleo, @hatakeyamak, @emilbols, @Martin-Grunewald, @bsunanda, @tlampen, @mbluj, @ahinzmann, @demuller, @seemasharmafnal, @venturia, @mmarionncern, @silviodonato, @JanFSchulte, @jhgoh, @jdolen, @HuguesBrun, @azotz, @cericeci, @fwyzard, @trocino, @rociovilar, @GiacomoSguazzoni, @rovere, @VinInn, @jdamgov, @nhanvtran, @gkasieczka, @tocheng, @schoef, @mmusich, @mtosi, @dgulhan, @AlexDeMoor, @adewit, @AnnikaStein, @Fedespring, @JyothsnaKomaragiri, @gpetruc, @mariadalfonso, @andrzejnovak this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@missirol missirol changed the title deprecate integer types for L1T and HLT prescales in HLTConfigProvider and its clients [12_5_X] deprecate integer types for L1T and HLT prescales in HLTConfigData and its clients [12_5_X] Sep 19, 2022
@missirol
Copy link
Contributor Author

type bugfix

#39220 (comment) : a backport to 12_5_X was asked because of the bugfix to MINIAOD.

@missirol
Copy link
Contributor Author

please test

@missirol missirol mentioned this pull request Sep 19, 2022
Merged
@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e667f4/27652/summary.html
COMMIT: 6c0922f
CMSSW: CMSSW_12_5_X_2022-09-19-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39446/27652/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3699454
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3699424
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@missirol
Copy link
Contributor Author

+hlt

To be clear, this backport is not strictly needed for HLT. The main beneficiary is MINIAOD.

@tvami
Copy link
Contributor

tvami commented Sep 19, 2022

+alca

@cecilecaillol
Copy link
Contributor

+l1

@mandrenguyen
Copy link
Contributor

+1

@missirol
Copy link
Contributor Author

@cms-sw/pdmv-l2 @cms-sw/dqm-l2

Do you have any comments on this backport?

@tvami
Copy link
Contributor

tvami commented Sep 20, 2022

urgent

  • needed for today's release

@kskovpen
Copy link
Contributor

+pdmv

@emanueleusai
Copy link
Member

+1

@rappoccio
Copy link
Contributor

+1

@rappoccio rappoccio merged commit 5877851 into cms-sw:CMSSW_12_5_X Sep 21, 2022
@missirol missirol deleted the devel_nonIntTriggerPrescales_125X branch September 21, 2022 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
alca-approved analysis-pending backport-ok bug-fix dqm-approved hlt-approved l1-approved orp-approved pdmv-approved pending-signatures reconstruction-approved tests-approved urgent
Projects
None yet
Milestone
CMSSW_12_5_X
Development

Successfully merging this pull request may close these issues.
8 participants
@missirol @cmsbuild @tvami @cecilecaillol @mandrenguyen @kskovpen @emanueleusai @rappoccio